docs: end-to-end SUMIT integration guide#16
Merged
Conversation
Field notes from a full production integration that SUMIT's own docs don't cover: Credentials (not Bearer) auth, CreateToken (not BindFormSubmit), Date_Start trials, the view-shaped webhook trigger (no EventType, ambiguous field names) + the id-match promotion strategy, the ?secret= base64-in-query 401 gotcha, getpdf returning the PDF binary, DocumentLanguage, and the hardening (idempotency, trial-conversion safety net, period-end finalizer). Includes a failure-mode→fix timeline. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 877c412562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenKalsky
added a commit
that referenced
this pull request
Jun 29, 2026
…e promotion (#18) Codex review (#16): - getpdf: Original is required by SUMIT's request schema; omitting it rejects the request before the PDF streams. Marked required + clarified DocumentID vs DocumentType/DocumentNumber pair. - view-charge promotion: matching an unmapped view record on sumitCustomerId alone can promote an unrelated successful charge (one-off invoice, different product) to recurring.charged. Require the sumitRecurringId marker. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive field notes from a full production integration (Aura) that SUMIT's docs don't cover — so future consumers of this package don't relearn it the hard way:
Credentialsbody object, not Bearer.CreateToken(notBindFormSubmit).Items[].Date_Start(deferred first charge).Folder/EntityID/Type/Properties) with no EventType and ambiguous field names → the id-match promotion strategy.?secret=base64-in-query 401 gotcha (+→space).getpdfreturns the PDF binary, not a JSON URL.DocumentLanguage(English=1).🤖 Generated with Claude Code